Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(flow): correctness bugs #4018

Merged
merged 22 commits into from
May 30, 2024
Merged

Conversation

discord9
Copy link
Contributor

@discord9 discord9 commented May 23, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

fix some correctness bugs

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • fix reorder of insert requests columns
  • fix choose the correct scalar function type
  • fix combine of avg&tumble cause transform errors
  • fix tumble ts < window start offset by one

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 23, 2024
@tisonkun tisonkun changed the title fix(flow): fix some bugs in flow fix(flow): correctness bugs in flow May 23, 2024
@tisonkun tisonkun changed the title fix(flow): correctness bugs in flow fix(flow): correctness bugs May 23, 2024
@discord9 discord9 marked this pull request as ready for review May 24, 2024 04:45
@discord9 discord9 requested review from zhongzc and waynexia as code owners May 24, 2024 04:45
@discord9 discord9 force-pushed the flow_fix_func_choose branch from 59da61a to 927c723 Compare May 24, 2024 04:46
@codecov-commenter
Copy link

codecov-commenter commented May 24, 2024

Codecov Report

Attention: Patch coverage is 76.74074% with 157 lines in your changes are missing coverage. Please review.

Project coverage is 85.04%. Comparing base (6e9a9dc) to head (e183323).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4018      +/-   ##
==========================================
- Coverage   85.34%   85.04%   -0.31%     
==========================================
  Files         987      987              
  Lines      171485   172079     +594     
==========================================
- Hits       146359   146344      -15     
- Misses      25126    25735     +609     

src/flow/src/adapter/flownode_impl.rs Outdated Show resolved Hide resolved
src/flow/src/adapter/node_context.rs Outdated Show resolved Hide resolved
src/flow/src/adapter/table_source.rs Outdated Show resolved Hide resolved
src/flow/src/transform/expr.rs Outdated Show resolved Hide resolved
src/flow/src/transform/expr.rs Outdated Show resolved Hide resolved
src/flow/src/utils.rs Outdated Show resolved Hide resolved
@discord9 discord9 added the release-blocker Indicates a release-blocker label May 27, 2024
@discord9 discord9 force-pushed the flow_fix_func_choose branch from 3535a52 to d815bdf Compare May 27, 2024 07:58
@discord9 discord9 mentioned this pull request May 27, 2024
8 tasks
@discord9 discord9 force-pushed the flow_fix_func_choose branch from d815bdf to 39504d9 Compare May 27, 2024 08:53
src/flow/src/adapter.rs Outdated Show resolved Hide resolved
Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others LGTM

src/flow/src/expr/error.rs Show resolved Hide resolved
src/flow/src/repr/relation.rs Show resolved Hide resolved
src/flow/src/transform/expr.rs Outdated Show resolved Hide resolved
src/flow/src/adapter.rs Show resolved Hide resolved
@discord9 discord9 force-pushed the flow_fix_func_choose branch 3 times, most recently from 12f06d5 to 305dd98 Compare May 29, 2024 12:14
@discord9 discord9 force-pushed the flow_fix_func_choose branch from 305dd98 to e183323 Compare May 30, 2024 03:29
@discord9 discord9 enabled auto-merge May 30, 2024 03:33
@discord9 discord9 added this pull request to the merge queue May 30, 2024
Merged via the queue into GreptimeTeam:main with commit 7de336f May 30, 2024
27 of 28 checks passed
@discord9 discord9 deleted the flow_fix_func_choose branch May 30, 2024 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs. release-blocker Indicates a release-blocker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants